Remove support for the ESP8266 #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
SergioGasquez
approved these changes
Feb 5, 2024
Comment on lines
+72
to
+73
| // TODO: the stub doesn't appear to disable the watchdog on ESP32-S3, so we | ||
| // explicitly disable the watchdog here. |
There was a problem hiding this comment.
Just remembered this todo, shall we open an issue and remove it?
There was a problem hiding this comment.
Ahh yeah good call, hopefully our stubs are doing this (can't remember) but if not we can update them as needed.
|
Realized I forgot to update |
SergioGasquez
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This morning @MabezDev, @SergioGasquez, and I had a discussion regarding this, and have decided to move forward with dropping support for the ESP8266.
I am still testing this so I will report back if I find any issues, but I think the changes are probably pretty straight forward.